Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] gpu_other_build.sh isn't running #12777

Closed
driazati opened this issue Sep 14, 2022 · 3 comments · Fixed by #13235
Closed

[ci] gpu_other_build.sh isn't running #12777

driazati opened this issue Sep 14, 2022 · 3 comments · Fixed by #13235
Labels
actionable has an immediately do-able work plan and a detailed description dev:ci type:ci Relates to TVM CI infrastructure

Comments

@driazati
Copy link
Member

driazati commented Sep 14, 2022 •
edited by github-actions bot
Loading

See discussion in #12644 for context, this test was being silently skipped before and has broken in the meantime. We should fix it and re-enable it

cc @Mousius @areusch @gigiblender
@driazati driazati added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure actionable has an immediately do-able work plan and a detailed description and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Sep 14, 2022
@alter-xp
Copy link
Contributor

hi @driazati @areusch @Mousius @gigiblender
The function camke_build does not use the passed in parameter path in ci/jenkins/Build.groovy.j2, which causes tests/scripts/task_build.py to use build as the compilation directory by default. So that task_config_build_gpu.sh and task_config_build_gpu_other is actually built in the same directory, not in the two directories written in the code (build and build2). Does anyone have any suggestions here？
Should we need to keep them compiled in the same directory? Or separate them?

@areusch
Copy link
Contributor

areusch commented Oct 17, 2022

@driazati could you have a look here?

@driazati
Copy link
Member Author

afaik the second build is just to test that the build is successful, so after we stash the first build we can delete it and run the second in the same folder, I think we just need to make sure we're clearing the cmake config in between.

@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@janetsc janetsc added dev:ci and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
alter-xp pushed a commit to alter-xp/tvm that referenced this issue Oct 31, 2022
@alter-xp
fix GPU other build
8d31e8a 
fix issuses apache#12777
@alter-xp alter-xp mentioned this issue Oct 31, 2022
Merged
alter-xp pushed a commit to alter-xp/tvm that referenced this issue Oct 31, 2022
@alter-xp
[ci] fix GPU other build
026ac9b 
fix issuses apache#12777
alter-xp pushed a commit to alter-xp/tvm that referenced this issue Nov 1, 2022
@alter-xp
[ci] fix GPU other build
3764ac6 
fix issuses apache#12777
driazati added a commit that referenced this issue Nov 1, 2022
@alter-xp @driazati
fix GPU other build (#13235)
e9e8c4b 
fixes #12777

Co-authored-by: thead_iot_autotest <thead_iot_autotest@alibaba-inc.com>
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
xinetzone pushed a commit to daobook/tvm that referenced this issue Nov 10, 2022
@alter-xp @driazati
fix GPU other build (apache#13235)
1d930eb 
fixes apache#12777

Co-authored-by: thead_iot_autotest <thead_iot_autotest@alibaba-inc.com>
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
alter-xp pushed a commit to alter-xp/tvm that referenced this issue Nov 14, 2022
@alter-xp
[ci] fix GPU other build
514c2e4 
fix issuses apache#12777
@alter-xp alter-xp mentioned this issue Nov 14, 2022
Merged
alter-xp added a commit to alter-xp/tvm that referenced this issue Nov 15, 2022
@alter-xp
[ci] fix GPU other build
17f0ebf 
fix issuses apache#12777
driazati pushed a commit that referenced this issue Nov 16, 2022
@alter-xp
[ci] fix GPU other build (#13366)
0d9b185 
Related pr #13235, #12777, #13261

because of ROCM build faild, pr #13235 destroyed CI.
this pr fixed that bug.
xinetzone pushed a commit to daobook/tvm that referenced this issue Nov 25, 2022
@alter-xp @driazati @xinetzone
fix GPU other build (apache#13235)
34ff626 
fixes apache#12777

Co-authored-by: thead_iot_autotest <thead_iot_autotest@alibaba-inc.com>
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
xinetzone pushed a commit to daobook/tvm that referenced this issue Nov 25, 2022
@alter-xp @xinetzone
[ci] fix GPU other build (apache#13366)
a517c3c 
Related pr apache#13235, apache#12777, apache#13261

because of ROCM build faild, pr apache#13235 destroyed CI.
this pr fixed that bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable has an immediately do-able work plan and a detailed description dev:ci type:ci Relates to TVM CI infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix GPU other build alter-xp/tvm
4 participants
@areusch @driazati @janetsc @alter-xp