-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Don't use latest main
for PRs
#12657
Comments
is this solved by #12604 ? i guess not, since it needs to know where they were moved to is the issue? |
right (this was actually caused by #12604), this issue would happen for any file referenced from the |
one thing is--is this just a one-time transient issue while we reorg the code tho? |
Yes, it can be fixed by the user by rebasing and thus changing the |
This adds some CI load by running PRs that would merge-conflict with main but improves UX by making it so CI is deterministic based on git history rather than when the PR happened to be submitted. Fixes apache#12657
This adds some CI load by running PRs that would merge-conflict with main but improves UX by making it so CI is deterministic based on git history rather than when the PR happened to be submitted. Fixes apache#12657
Here we find the latest commit and merge with it before running a PR through CI to prevent merge conflicted PRs from taking up CI time.
tvm/ci/jenkins/Prepare.groovy.j2
Lines 17 to 26 in caf326f
This is fine except when we change the
Jenkinsfile
that always comes from the PR'sgit merge-base origin/main <pr_commit>
, so if that references files that have been moved in the latest commit onmain
there will be random CI failures like https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12648/3/pipeline/. To fix this we should either:origin/main
and thegit merge-base origin/main <pr_commit>
that has noJenkinsfile
modifications) and merge to thatcc @Mousius @areusch @gigiblender
The text was updated successfully, but these errors were encountered: