Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Assert that Jenkinsfile changes also change the timestamp #12388

Closed
driazati opened this issue Aug 11, 2022 · 1 comment
Closed

[ci] Assert that Jenkinsfile changes also change the timestamp #12388

driazati opened this issue Aug 11, 2022 · 1 comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure

Comments

@driazati
Copy link
Member

driazati commented Aug 11, 2022 •
edited by github-actions bot
Loading

Concurrent Jenkinsfile changes that happen in a sequence like:

  1. PR 1 makes changes
  2. PR 2 makes changes
  3. PR 1 merges
  4. PR 2 merges

Can create a situation where both PRs pass CI but break main when merged with failures like https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4024/pipeline.

There is a timestamp in the Jenkinsfile that makes it so these PRs will have a merge conflict (in the example above PR 2 must be rebased and run through CI again before it can merge), we should check that any changes to the Jenkinsfile also change this timestamp (so if say PR 2 did not change the timestamp it wouldn't pass PR CI)

cc @Mousius @areusch @gigiblender
driazati added a commit to driazati/tvm that referenced this issue Aug 11, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
21b77a5 
This closes apache#12388
@driazati driazati mentioned this issue Aug 11, 2022
Closed
driazati added a commit to driazati/tvm that referenced this issue Aug 11, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
d8313ef 
This closes apache#12388
driazati added a commit to driazati/tvm that referenced this issue Aug 11, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
257134d 
This closes apache#12388
driazati added a commit to driazati/tvm that referenced this issue Aug 11, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
24f9c73 
This closes apache#12388
@areusch areusch added the type:ci Relates to TVM CI infrastructure label Aug 12, 2022
driazati added a commit to driazati/tvm that referenced this issue Aug 19, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
bb17a32 
This closes apache#12388
driazati added a commit to driazati/tvm that referenced this issue Aug 25, 2022
@driazati
[ci] Check for timestamps in Jenkinsfile changes
1cbcae1 
This closes apache#12388
@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@driazati
Copy link
Member Author

This isn't necessary in all cases anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci] Check for timestamps in Jenkinsfile changes driazati/tvm
2 participants
@areusch @driazati