Skip to content

Commit

Permalink
addres review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
huajsj committed Dec 16, 2021
1 parent a9bf2a5 commit 60f98af
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/runtime/pipeline/pipeline_executor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void PipelineExecutor::Init(const std::vector<Module>& modules, const std::strin
// Use JSONReader to load pipeline configuration.
std::istringstream is(pipeline_json);
dmlc::JSONReader reader(&is);
ConfigPipelineExecution& pipeline_config = this->LoadConfigPipelineExecution(&reader);
ConfigPipelineExecution& pipeline_config = this->LoadConfig(&reader);
ICHECK(!pipeline_config.Empty()) << "The pipeline config information is empty.";
// Initialize the pipeline function class used for pipeline thread pool management
// and schedule etc. This function returns the number of output.
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/pipeline/pipeline_executor.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class TVM_DLL PipelineExecutor : public ModuleNode {
/*!\brief How many outputs are in this pipeline executor.*/
size_t num_outputs_ = 0;
/*!\brief Json loader.*/
ConfigPipelineExecution& LoadConfigPipelineExecution(dmlc::JSONReader* reader) {
ConfigPipelineExecution& LoadConfig(dmlc::JSONReader* reader) {
reader->BeginObject();
std::string key;
while (reader->NextObjectItem(&key)) {
Expand Down
3 changes: 1 addition & 2 deletions src/runtime/pipeline/pipeline_struct.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,13 @@
#include <unordered_map>
#include <utility>
#include <vector>
#define GLOBAL_MODULE_INDEX -1
/*!
* \brief All binding information of a output interface.
*/
class ConfigBindings {
public:
/*!\brief Whether this binding is bound to the PipelineExecutor output interface.*/
bool IsGlobalOutput() const { return global_output_index_ > GLOBAL_MODULE_INDEX; }
bool IsGlobalOutput() const { return global_output_index_ > -1; }

/*!
* \brief Create a module interface map from JSONReader.
Expand Down

0 comments on commit 60f98af

Please sign in to comment.