Skip to content

Conversation

@oraluben
Copy link
Contributor

@oraluben oraluben commented Oct 28, 2025

As title, currently it failed with ml_dtypes==0.4.x: tile-ai/tilelang#1108 (comment)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @oraluben, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the tvm_ffi's Cython bindings by enhancing its compatibility with different versions of the ml_dtypes library. It refactors the data type mapping mechanism to dynamically adapt to the presence or absence of certain data types, specifically those introduced in ml_dtypes version 0.5.0 and later. This modification prevents crashes and ensures the system can operate smoothly with a wider range of ml_dtypes installations.

Highlights

  • Conditional ml_dtypes Mapping: The pull request introduces conditional logic to map specific ml_dtypes types (such as int2, uint2, and various float8 and float6 types) to DLDataType only if these types are present in the ml_dtypes library.
  • Backward Compatibility: This change ensures backward compatibility with ml_dtypes versions older than 0.5.0, preventing runtime errors that would occur if the code attempted to access types not available in those older versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces support for ml_types<0.5 by adding a conditional check for the existence of int2 attribute in the ml_dtypes module. Based on the presence of this attribute, the code maps additional data types from the ml_dtypes module to their corresponding DLDataType representations. This ensures compatibility with older versions of the ml_dtypes library.

@oraluben oraluben changed the title feat: support ml_types<0.5 feat: support ml_dtypes<0.5 Oct 28, 2025
@tqchen tqchen merged commit 9574e9d into apache:main Oct 28, 2025
7 checks passed
@oraluben oraluben deleted the ml_types-0.4 branch October 28, 2025 15:08
@oraluben
Copy link
Contributor Author

fyi: this works for ml_dtypes > 0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants