-
Notifications
You must be signed in to change notification settings - Fork 73
Colin fix config #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colin fix config #493
Conversation
b0dcb7d
to
fe101c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes configuration-related issues and updates API signatures while adding new functions for retrieving and setting TsFile configuration. Key changes include updating Python type annotations in writer classes, adding new cpdef functions for configuration in the C/C++ binding, and adjusting C++ global configuration and encoding functions.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
python/tsfile/tsfile_writer.pyx | Added type annotations to the init function |
python/tsfile/tsfile_table_writer.py | Updated constructor signature to include memory_threshold |
python/tsfile/tsfile_py_cpp.pyx | Added get_tsfile_config and set_tsfile_config implementations |
python/tsfile/tsfile_py_cpp.pxd | Declared new cpdef functions for configuration |
python/tests/test_write_and_read.py | Added tests for the new configuration functions |
python/setup.py | Adjusted header copying logic and library copy routines |
cpp/test/cwrapper/c_release_test.cc | Fixed file naming for test cleanup |
cpp/src/utils/db_utils.h, etc. | Updated configuration functions and default encoding/compression retrieval |
cpp/src/encoding/gorilla_decoder.h | Changed initialization of has_next_ in GorillaDecoder |
cpp/src/common/global.h and related files | Updated global config functions to utilize dynamic configuration values |
Comments suppressed due to low confidence (1)
cpp/src/encoding/gorilla_decoder.h:47
- Changing the initialization of 'has_next_' from true to false may disrupt the intended iteration logic. Please confirm that this new default value is correct according to the overall decoding algorithm.
has_next_ = false;
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #493 +/- ##
===========================================
+ Coverage 65.48% 65.69% +0.20%
===========================================
Files 565 565
Lines 33040 33061 +21
Branches 4603 4610 +7
===========================================
+ Hits 21636 21718 +82
+ Misses 10762 10690 -72
- Partials 642 653 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
755b349
to
2a6b7df
Compare
Uh oh!
There was an error while loading. Please reload this page.