Skip to content

Colin fix config #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Colin fix config #493

merged 3 commits into from
May 13, 2025

Conversation

ColinLeeo
Copy link
Contributor

@ColinLeeo ColinLeeo commented May 13, 2025

截屏2025-05-13 14 21 56

@ColinLeeo ColinLeeo requested review from jt2594838, Copilot and HTHou May 13, 2025 06:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes configuration-related issues and updates API signatures while adding new functions for retrieving and setting TsFile configuration. Key changes include updating Python type annotations in writer classes, adding new cpdef functions for configuration in the C/C++ binding, and adjusting C++ global configuration and encoding functions.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
python/tsfile/tsfile_writer.pyx Added type annotations to the init function
python/tsfile/tsfile_table_writer.py Updated constructor signature to include memory_threshold
python/tsfile/tsfile_py_cpp.pyx Added get_tsfile_config and set_tsfile_config implementations
python/tsfile/tsfile_py_cpp.pxd Declared new cpdef functions for configuration
python/tests/test_write_and_read.py Added tests for the new configuration functions
python/setup.py Adjusted header copying logic and library copy routines
cpp/test/cwrapper/c_release_test.cc Fixed file naming for test cleanup
cpp/src/utils/db_utils.h, etc. Updated configuration functions and default encoding/compression retrieval
cpp/src/encoding/gorilla_decoder.h Changed initialization of has_next_ in GorillaDecoder
cpp/src/common/global.h and related files Updated global config functions to utilize dynamic configuration values
Comments suppressed due to low confidence (1)

cpp/src/encoding/gorilla_decoder.h:47

  • Changing the initialization of 'has_next_' from true to false may disrupt the intended iteration logic. Please confirm that this new default value is correct according to the overall decoding algorithm.
has_next_ = false;

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (217cc3c) to head (2a6b7df).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
cpp/src/common/global.cc 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #493      +/-   ##
===========================================
+ Coverage    65.48%   65.69%   +0.20%     
===========================================
  Files          565      565              
  Lines        33040    33061      +21     
  Branches      4603     4610       +7     
===========================================
+ Hits         21636    21718      +82     
+ Misses       10762    10690      -72     
- Partials       642      653      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 6f08fb1 into develop May 13, 2025
44 checks passed
@HTHou HTHou deleted the colin_fix_config branch May 14, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants