Skip to content

Add automatic detection of ccache for cmake #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 2 commits into from
May 22, 2023
Merged

Add automatic detection of ccache for cmake #9720

bryancall merged 2 commits into from
May 22, 2023

Conversation

@bryancall
Copy link
Contributor

@bryancall bryancall commented May 18, 2023 •
edited
Loading

Builds time change from about 20 seconds to 3.5 seconds.

Without ccache:

13:57:06 zeus:(cmake_ccache)~/dev/apache/trafficserver/target$ time ninja
[0/2] Re-checking globbed directories...
[497/497] Linking CXX executable src/traffic_server/traffic_server

real	0m19.219s
user	7m50.807s
sys	0m53.087s

With ccache:

13:53:11 zeus:(cmake_ccache)~/dev/apache/trafficserver/target$ time ninja
[0/2] Re-checking globbed directories...
[497/497] Linking CXX executable src/traffic_server/traffic_server

real	0m3.525s
user	0m9.939s
sys	0m4.739s

@bryancall bryancall added the Build work related to build configuration or environment label May 18, 2023
@bryancall bryancall added this to the 10.0.0 milestone May 18, 2023
@bryancall bryancall requested a review from cmcfarlen May 18, 2023 20:52
@bryancall bryancall self-assigned this May 18, 2023
@ezelkow1
Copy link
Member

ezelkow1 commented May 19, 2023

[approve ci centos]

bneradt
bneradt reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bryancall bryancall merged commit fba8223 into apache:master May 22, 2023
@bneradt bneradt added the CMake work related to CMakes scripts or issues label Jun 13, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
f17a28a 
* asf/master:
  Fix PROXY protocol out with tls (apache#9698)
  Add automatic detection of ccache for cmake (apache#9720)
  Fix cqpv log field value on H3 connections (apache#9719)
  system_stats: fix buffer overflow caught by asan (apache#9723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt left review comments

@zwoop zwoop zwoop approved these changes

@cmcfarlen cmcfarlen Awaiting requested review from cmcfarlen

Assignees

@bryancall bryancall

Labels

Build work related to build configuration or environment CMake work related to CMakes scripts or issues

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bryancall @ezelkow1 @zwoop @bneradt