Skip to content

Add error log for invalid OCSP response #9674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 2 commits into from
May 10, 2023
Merged

Add error log for invalid OCSP response #9674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7696c6a
Add error log for invalid OCSP response
maskit May 2, 2023
1df7130
Check times only if status is available
maskit May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion iocore/net/OCSPStapling.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,10 @@ stapling_check_response(certinfo *cinf, TS_OCSP_RESPONSE *rsp)
// If ID not present just pass it back to client
Error("stapling_check_response: certificate ID not present in response for %s", cinf->certname);
} else {
TS_OCSP_check_validity(thisupd, nextupd, 300, -1);
if (!TS_OCSP_check_validity(thisupd, nextupd, 300, -1)) {
// The check is just for logging and pass the response back to client anyway
Error("stapling_check_response: status in response for %s is not valid already/yet", cinf->certname);
}
}

switch (status) {
Expand Down