Don't build native QUIC implementation #9670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
reviewed
May 3, 2023
Comment on lines
+1440
to
+1441
| AC_SUBST(use_quic) | ||
| AC_SUBST(has_quiche) |
Contributor
There was a problem hiding this comment.
use_quic or quiche both imply the same things from now on, so I wonder if we should keep two separate variables for the QUIC implementation.
No need to change this now anyway, but we can agree and add task for it.
Member
Author
There was a problem hiding this comment.
I thought I can remove it, and I still think we should remove it, but I kept it for now. Because there are files that are used for the both native impl and quiche impl (e.g. iocore/net/QUICNet.cc), and those files #if TS_HAS_QUICHE .
brbzull0
approved these changes
May 4, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (33 commits) Add error log for invalid OCSP response (apache#9674) Add new settings to specify TLS versions to use (apache#9667) Remove flask from tests/Pipfile (apache#9688) Doc: Add example of --enable-lto build option with LLVM (apache#9654) Added Zhengxi to the asf contributors (apache#9685) Don't build native QUIC implementation (apache#9670) Stabilize autest tls_hooks17 (apache#9671) Cleanup: remove ts::buffer from HostDB. (apache#9677) Fix leak in MultiTextMod in ControlBase. (apache#9675) Cleanup: remove TsBuffer.h from MIME.cc (apache#9661) Cleanup: remove ts::Buffer from ControlBase. (apache#9664) setup pre-commit hook at cmake generation time (apache#9669) Updated parent retry attempt logic (apache#9620) Try to do less work in hot function HttpHookState::getNext (apache#9660) cmake build, fixed warning using older openssl APIs (apache#9648) rename attempts to retry_attempts (apache#9655) OCSP: Fix unitialized variable error. (apache#9662) Add support for CONNECT method on HTTP/2 connection (apache#9616) Remove deprecated debug output functions from 10 source files. (apache#9657) Remove deprecated debug output functions from 14 source files. (apache#9658) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we decided to use Quiche and remove the code for ATS's native QUIC implementation, I found that keeping the code on master branch is actually handy and helpful, because I can read/copy the code easily when I implement outgoing QUIC connection with Quiche (the native impl supported outgoing connection).
This PR removes the filenames for the native implementation from Makefiles for now so we don't have to maintain the code, and keeps actual files for reference.
We'll remove the files when we get outgoing QUIC connection work with Quiche.