Add support for tunnel route config that has both match group and port variable #9594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
requested changes
Apr 10, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Thanks for fixing this @lzx404243.
bneradt
previously approved these changes
Apr 14, 2023
cmcfarlen
requested changes
Apr 14, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
The documentation could better match the code and I feel the code should handle the case where both port strings appear (even if that means a warning or error).
Member
|
I'll defer to @brbzull0 and @cmcfarlen but otherwise I think it's fine. |
lzx404243
force-pushed
the
tunnel_route_match_group_and_port
branch
from
2cab5f2 to
d3142a0
Compare
cmcfarlen
previously approved these changes
Apr 14, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
The new code to add the function is a little hard to read imo.
cmcfarlen
approved these changes
Apr 14, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
Thank you for cleaning that up.
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
…t variable (apache#9594) (apache#804) Conflicts: doc/admin-guide/files/sni.yaml.en.rst iocore/net/P_SNIActionPerformer.h tests/gold_tests/tls/tls_tunnel.test.py Co-authored-by: Zhengxi Li <zli11@yahooinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
tunnel_routeconfiguration that contains both the regex match group number and the port variable specification, such as the followingPrior to this PR, only one of the match group specification or port variable specification can be used in the
tunnel_routeconfiguration.