Skip to content

Conversation

@bneradt
Copy link
Contributor

@bneradt bneradt commented Jan 17, 2023

When Sphinx 4.x was initially released there were rendering issues with it building the ATS docs. To address this we simply pinned to the 3.x releases. Currently the latest Sphinx release is v6.1.3 and I noticed that unpinning doesn't have issues with our code anymore. This therefore unpins Sphinx. This also addresses a deprecated use of set_class from traffic-server.py.

@bneradt bneradt added this to the 10.0.0 milestone Jan 17, 2023
@bneradt bneradt requested a review from zwoop January 17, 2023 19:37
@bneradt bneradt self-assigned this Jan 17, 2023
zwoop
zwoop previously approved these changes Jan 17, 2023
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the Python version issues, and the set_class() changes fixes the "make html" targets.

When Sphinx 4.x was initially released there were rendering issues with
it building the ATS docs. To address this we simply pinned to the 3.x
releases. Currently the latest Sphinx release is v6.1.3 and I noticed
that unpinning doesn't have issues with our code anymore. This therefore
unpins Sphinx. This also addresses a deprecated use of set_class from
traffic-server.py.
@bneradt bneradt merged commit b2f2f00 into apache:master Jan 17, 2023
zwoop pushed a commit that referenced this pull request Jan 17, 2023
When Sphinx 4.x was initially released there were rendering issues with
it building the ATS docs. To address this we simply pinned to the 3.x
releases. Currently the latest Sphinx release is v6.1.3 and I noticed
that unpinning doesn't have issues with our code anymore. This therefore
unpins Sphinx. This also addresses a deprecated use of set_class from
traffic-server.py.

(cherry picked from commit b2f2f00)

 Conflicts:
	doc/Pipfile
@zwoop
Copy link
Contributor

zwoop commented Jan 17, 2023

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Jan 17, 2023
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Fixed issue with SDK_API_HttpParentProxySet_Fail regression test (apache#9300)
  Updated warning message for adding duplicated remap entries (apache#9306)
  AuTests: update to Proxy Verifier v2.6.0 (apache#9307)
  glibc 2.37 will require additional explicit defines (apache#9325)
  ppc64 stack grows down (apache#9326)
  Fixes header level for remap inspector
  Updated ChangeLog
  Bump version to v9.2.0
  Finished the 9.2.x release notes
  Checkpoint so far, on page 10 out of 24
  Update rtd-theme to the latest version (apache#9316)
  Cleanup and prepare for 9.2.x sections
  Docs: Unpin Sphinx (apache#9311)
@bneradt bneradt deleted the unpin_shinx branch March 29, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants