Skip to content

Updated warning message for adding duplicated remap entries #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 2 commits into from
Jan 13, 2023
Merged

Updated warning message for adding duplicated remap entries #9306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec83bc
Updated log message
lzx404243 Jan 13, 2023
1adc0ce
Added a comment
lzx404243 Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion proxy/http/remap/UrlRewrite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,8 @@ UrlRewrite::TableInsert(std::unique_ptr<URLTable> &h_table, url_mapping *mapping
h_table->emplace(src_host, ht_contents);
}
if (!ht_contents->Insert(mapping)) {
Warning("Could not insert new mapping");
// Trie::Insert only fails due to an attempt to add a duplicate entry.
Warning("Could not insert new mapping: duplicated entry exists");
return false;
}
return true;
Expand Down