TS-4725: Remove proxy.config.http.enable_url_expandomatic #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci] |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/609/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/505/ for details. |
Contributor
|
It looks like we can go futher and remove |
Contributor
|
Be careful when eliminating try_to_expand_host_name(), I recently discovered that this function also deals with DNS failures in parent selection. I'm +1 on removing (or renaming) this method, but it can't just be blindly removed. |
Contributor
|
OK I filed TS-4792. |
Contributor
|
👍 |
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 8, 2024
This is a format-only change. Somehow applying the format target was missed on a previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all references to proxy.config.http.enable_url_expandomatic in code and documentation.