File change monitoring on s3_auth (#8905) #8960
Conversation
|
Looks like the gold file doesn't quite match curl's output: Probably good to replace lines that aren't strictly relevant to the test output with ``. In case it's helpful, issues like this make me lean toward using Proxy Verifier in AuTests. It has a purpose built field verification mechanism rather than the generic gold comparison. |
moonchen
force-pushed
the
inotify-s3-auth
branch
from
a463153 to
c2a91e9
Compare
|
My text editor trimmed trailing whitespace from the gold file. It looks like the other gold file to match ATS log output also failed. I'm investigating. |
This reverts commit e93063e. PR apache#8905 was accidentally filed against 9.2.x instead of master. @moonchen filed a new PR for master via apache#8960, so the work will continue with that PR. Since this patch is not intended for 9.2.x, this PR reverts the commit.
|
Autest failure should be fixed with latest push. Thanks @bneradt |
include/ts/apidefs.h.in
Outdated
| TS_EVENT_FILE_CREATED = 60300, | ||
| TS_EVENT_FILE_UPDATED = 60301, | ||
| TS_EVENT_FILE_DELETED = 60302, | ||
| TS_EVENT_FILE_IGNORED = 60303, | ||
|
|
||
| TS_EVENT_MGMT_UPDATE = 60300 |
There was a problem hiding this comment.
Just checking: is it intentional that TS_EVENT_FILE_CREATED and TS_EVENT_MGMT_UPDATE have the same enum value?
There was a problem hiding this comment.
Definitely not. Thanks for catching that. I've moved file events so they no longer conflict.
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
Couple of things to do before we can merge:
- This needs to be discussed on the mailing list, as is the normal process for adding new plugin APIs. A short description of the new APIs, with the prototypes etc., and a justification.
- These new APIs only work on Linux, which I feel reasonably strongly is not acceptable. I don't think we have any other APIs that are Linux only. So, we'll need to add kqueue support to this as well please :).
|
Also, removing 9.2.x from this, we'll add this new API and plugin changes for 10.0.x. |
10.0 has a change where ATS logs are sent to traffic.log by default.
Move file monitoring events so they're not conflicting with MGMT.
moonchen
force-pushed
the
inotify-s3-auth
branch
from
41c90ff to
fa6eb6a
Compare
|
-Reader and writer need to agree on a method -flock isn't supported by C++ standard library file I/O methods
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
3 participants
(Previously I made PR #8905 against 9.2.x by mistake. It should have been against master branch. This PR is rebased on top of master. It also incorporates an autest change suggested by @bneradt.)