TS-4763: Consistent request bytes logging tags. #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/554/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/450/ for details. |
|
|
||
| len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id); | ||
| marshal_str(buf, str, round_strlen(len + 1)); | ||
| len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id); |
Contributor
There was a problem hiding this comment.
Isn't this fixed/addressed in a separate PR?
Contributor
Author
There was a problem hiding this comment.
On Aug 18, 2016, at 7:25 PM, Leif Hedstrom notifications@github.com wrote:
In proxy/logging/LogAccessHttp.cc:
@@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
const char *uuid = (char *)Machine::instance()->uuid.getString();
int len;
- len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
- marshal_str(buf, str, round_strlen(len + 1));
- len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id);
Isn't this fixed/addressed in a separate PR?Yeh I just branched this from the other PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Standardize on content_len terminology for logging, so rename "body_len" log access methods to "content_len".
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/558/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/454/ for details. |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 6, 2024
* HttpConnectionCount move to iocore/net This moves HttpConnectionCount to iocore/net from proxy/http in anticipation to using its functionality on the client accept connection side. While doing so, this also renames HttpConnectionCount to ConnectionTracker because it is no longer HTTP transaction specific. * Build updates for test_net Moving ConnectionTracker to iocore/net induced linking behavior differences that required these changes to fix test_net. * Fix tls_bridge to use Regex from tscore tls_bridge had previously linked to tscore, but had copied in its own version of Regex. This removes the duplicated code and logic which, with these changes, caused duplicate definitions errors. (cherry picked from commit fc3f12e) Conflicts: include/proxy/http/HttpConnectionCount.h include/proxy/http/HttpProxyAPIEnums.h include/shared/overridable_txn_vars.h iocore/cache/test/main.cc iocore/net/ConnectionTracker.cc iocore/net/ConnectionTracker.h iocore/net/Makefile.am iocore/net/SessionSharingAPIEnums.h iocore/net/libinknet_stub.cc plugins/experimental/tls_bridge/CMakeLists.txt plugins/experimental/tls_bridge/tls_bridge.cc proxy/PoolableSession.h proxy/http/Http1ServerSession.h proxy/http/HttpConfig.h proxy/http/HttpConnectionCount.cc proxy/http/HttpConnectionCount.h proxy/http/HttpProxyAPIEnums.h proxy/http/HttpProxyServerMain.cc proxy/http/HttpSM.cc proxy/http/HttpTransact.h src/api/CMakeLists.txt src/iocore/net/CMakeLists.txt src/proxy/http/CMakeLists.txt src/proxy/http/HttpConfig.cc src/proxy/http/HttpConnectionCount.cc src/shared/overridable_txn_vars.cc src/tests/CMakeLists.txt src/traffic_server/InkAPI.cc Co-authored-by: Brian Neradt <brian.neradt@gmail.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
May 29, 2025
* check stat is not null * remove debug ctl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the byte count logging tags consistent. We have
cqbl- client request body lengthcqhl- client request header lengthpscl- client response body lengthpshl- client response header lengthpsql- client response total lengthpqbl- server request body lengthpqhl- server request header lengthsscl- server response body lengthsshl- server response header lengthWe should add
*qlto get the missing totals and standardize on*clfor the content length (cssclmarginally tips the balance towards "content length" in favor of "body length").