Skip to content

Conversation

@randall
Copy link
Contributor

@randall randall commented Apr 18, 2022

This is an origin intercept-based remap plugin for exposing ATS's stats over HTTP.

@randall randall added this to the 10.0.0 milestone Apr 18, 2022
@randall randall requested a review from ezelkow1 April 18, 2022 18:12
@randall randall self-assigned this Apr 18, 2022
@randall randall requested review from bryancall and zwoop as code owners April 18, 2022 18:12
@randall
Copy link
Contributor Author

randall commented Apr 18, 2022

This is a copy/paste/merge of stats_over_http + statichit plugins with the features exposed in stats_over_http removed since they're covered by other plugins (compress) or can use features in remap (eg ACLs)

@bryancall bryancall requested a review from rob05c April 18, 2022 23:18
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would like @ezelkow1 to review before we commit.

@randall randall force-pushed the http_stats branch 3 times, most recently from 8679305 to e237cf9 Compare April 19, 2022 20:44
This is an origin intercept-based remap plugin for exposing ATS's stats
over HTTP
@ywkaras
Copy link
Contributor

ywkaras commented Apr 19, 2022

I've gotten pulled off onto a Yahoo internal issue. I'll try to review this before the end of the week, or someone else can step in if they like.

Copy link
Member

@ezelkow1 ezelkow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but haven't had a chance to play with it yet. It is experimental anyway so not much harm if it still has issues

@randall randall merged commit 2aa1d31 into apache:master Apr 20, 2022
@randall randall deleted the http_stats branch April 20, 2022 19:51
zwoop pushed a commit that referenced this pull request Apr 20, 2022
This is an origin intercept-based remap plugin for exposing ATS's stats
over HTTP

(cherry picked from commit 2aa1d31)
@zwoop
Copy link
Contributor

zwoop commented Apr 20, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Apr 20, 2022
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request May 26, 2022
* asf/9.2.x:
  Updated ChangeLog
  HttpSM, HttpTunnel, and Http2Stream debug logging updates (apache#8788)
  Fix plugin parent_select failover (apache#8676)
  Adds new plugin, http_stats (apache#8797)
  SIGTERM should cause traffic_manager to exit with status 0 as a shutdown method (apache#8798)
  Avoid allocation when matching hosts for vol lookup (apache#8762)
  Check bounds before accessing Vol::evacuate array (apache#8716)
  Adds a simple tool to generate new escape tables (apache#8783)
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Jul 26, 2022
This is an origin intercept-based remap plugin for exposing ATS's stats
over HTTP

(cherry picked from commit 2aa1d31)

Conflicts:
    plugins/Makefile.am
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants