include <cstring> for access to C-string operations #8786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci] |
bneradt
approved these changes
Apr 11, 2022
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good Jered. I've added your username to the CI allow list so your PRs will have the CI run. Thank you for the contribution.
Contributor
|
Marking this for 9.2.x to address GCC 12 build issues there. These files do not exist in 8.1.x, so not marking for that release. |
zwoop
pushed a commit
that referenced
this pull request
Apr 11, 2022
(cherry picked from commit 02e58e0)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
* asf/9.2.x: Updated ChangeLog Serve stale content when DNS lookup fails (apache#8484) Reuse TSMutex for ts_lua_http_intercept_handler (apache#8687) include <cstring> for access to C-string operations (apache#8786) Propagate proxy.config.net.sock_option_flag_in to newly accepted connections (apache#8784)
bryancall
pushed a commit
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit 02e58e0)
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
(cherry picked from commit 02e58e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 12 (libstdc++12) no longer provides strlen() via <string>; these files must #include <cstring> to build on Fedora 36 and later.
Also, hello! I am planning to be the Fedora/EPEL package maintainer for ATS. I'll introduce myself on the mailing list once I have a successfully building Copr repo.