backport of 9.2.x autest port selection fixes. #8668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're running into issues with port selection with our tests. This seems to be an issue with recycled ports. This temporarily expands the number of ports in the port pool to avert this problem while we investigate this issue further. (cherry picked from commit d15a042)
(cherry picked from commit b9668b7)
Our port queue wound up having duplicates in it. We never want duplicates in our port queue as this results in multiple processes trying to use the same port leading to EADDRINUSE errors. Since unique port entries is a requirement, this changes the port queue to be an ordered set queue which, by design, will only contain unique port values. (cherry picked from commit 2784e0b)
…" (apache#8300) This reverts commit d15a042. This port pool expansion should no longer be needed now that the port queue was made a unique set (see apache#8299). This commit therefore reverts what was intended to be temporary. (cherry picked from commit 6d4f919)
traeak
changed the title
bneradt
approved these changes
Feb 14, 2022
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks fine. This is a simple backport from master/9.2.x to 9.1.x.
zwoop
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.