Skip to content

Fixed issues when compiling with -Og #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 1 commit into from
Feb 14, 2022
Merged

Fixed issues when compiling with -Og #8665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iocore/cache/Cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,7 @@ Vol::handle_recover_from_data(int event, void * /* data ATS_UNUSED */)
{
uint32_t got_len = 0;
uint32_t max_sync_serial = header->sync_serial;
char *s, *e;
char *s, *e = nullptr;
if (event == EVENT_IMMEDIATE) {
if (header->sync_serial == 0) {
io.aiocb.aio_buf = nullptr;
Expand Down
2 changes: 1 addition & 1 deletion proxy/http2/HTTP2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ http2_convert_header_from_1_1_to_2(HTTPHdr *headers)

// :path
if (MIMEField *field = headers->field_find(HTTP2_VALUE_PATH, HTTP2_LEN_PATH); field != nullptr) {
int value_len;
int value_len = 0;
Copy link
Contributor

@masaori335 masaori335 Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty interesting that line 589 above is almost the same situation but doesn't need initialization.

const char *value = headers->path_get(&value_len);

ts::LocalBuffer<char> buf(value_len + 1);
Expand Down
2 changes: 1 addition & 1 deletion tests/gold_tests/chunked_encoding/smuggle-client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ main(int argc, char *argv[])
{
struct addrinfo hints;
struct addrinfo *result, *rp;
int sfd, s;
int sfd = -1, s;

if (argc < 3) {
fprintf(stderr, "Usage: %s <target addr> <target_port>\n", argv[0]);
Expand Down
2 changes: 1 addition & 1 deletion tests/gold_tests/tls/ssl-post.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ main(int argc, char *argv[])
{
struct addrinfo hints;
struct addrinfo *result, *rp;
int sfd, s;
int sfd = -1, s;

if (argc < 4) {
fprintf(stderr, "Usage: %s host thread-count header-count [port]\n", argv[0]);
Expand Down