Revert fixes for #8539 #8637
Merged
Revert fixes for #8539 #8637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing apache#8539 is easy to do in a common case, but it causing issues in corner cases. For now I'm going to revert the fixes for this and circle back around later to see whether this can be solved in a different way. This reverts the following commits: Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621)" This reverts commit 4678ae3 Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617)" This reverts commit 235c44a. Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (apache#8545)" This reverts commit 080e236.
bneradt
requested review from
SolidWallOfCode,
bryancall and
zwoop
as code owners
zwoop
approved these changes
Jan 31, 2022
This was referenced Jan 31, 2022
zwoop
pushed a commit
that referenced
this pull request
Feb 2, 2022
Fixing #8539 is easy to do in a common case, but it causing issues in corner cases. For now I'm going to revert the fixes for this and circle back around later to see whether this can be solved in a different way. This reverts the following commits: Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (#8621)" This reverts commit 4678ae3 Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (#8617)" This reverts commit 235c44a. Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (#8545)" This reverts commit 080e236. (cherry picked from commit 2f1bd0f)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog Prevent calling SSL_set_session in the middle of handshake (apache#8600) Change the function signature of safe_[get|set]sockopt (apache#8331) Revert fixes for apache#8539 (apache#8637) Update descriptions of sni.yaml.default (apache#8568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #8539 is easy to do in a common case, but it causing issues in
corner cases. For now I'm going to revert the fixes for this and circle
back around later to see whether this can be solved in a different way.
This reverts the following commits:
Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (#8621)"
This reverts commit 4678ae3
Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (#8617)"
This reverts commit 235c44a.
Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (#8545)"
This reverts commit 080e236.