Add parent_select plugin autests #8602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports apache#7897 from core strategies to parent_select plugin. Adds a new peering_ring mode to strategies, which allows parenting to a consistent-hashed peer instead of the next hierarchical tier, which can be useful in many situations, especially when the requesting client itself is requesting different caches for the same key.
Ports apache#7925 and apache#8365 from core strategies to parent_select plugin. PR apache#7925 adds go_direct support to peering_ring strategies. PR apache#8365 refactors strategy consistent hashing to fix a bug. They both essentially completely rewrite the strategy consistent hashing, so it was safer and easier to port them both at the same time.
rob05c
force-pushed
the
add-parent-select-plugin-tests
branch
2 times, most recently
from
c12bef8 to
1ed51b5
Compare
Contributor
|
[approve ci debian] |
Tests are mostly copied from the core strategies tests, which makes sense since the plugin strategies should behave the same as core.
rob05c
force-pushed
the
add-parent-select-plugin-tests
branch
from
1ed51b5 to
847c56a
Compare
Member
Author
|
The contents of this PR have been added to #8590 as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are mostly copied from the core strategies tests, which makes
sense since the plugin strategies should behave the same as core.