LGTM: Remove function declaration in block (HdrHeap.cc) #8588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
approved these changes
Jan 10, 2022
zwoop
pushed a commit
that referenced
this pull request
Jul 13, 2022
(cherry picked from commit d5ecba8)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit d5ecba8)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: (22 commits) Updated ChangeLog Add 5xx's to be allowed to be used for simple retries (apache#8518) Extend milestone api time tracking to remap. (apache#8520) Destroy ssl context after use. (apache#8531) Proxy Verifier: Update to version 2.4.1 (apache#8965) Fixes issue with file size calculation for existing logs (apache#8971) Fix reverting PR#7302 (apache#8975) add a metric to track how often the range seek bug is detected (apache#8970) Updated ChangeLog Revert "File change monitoring on s3_auth (apache#8905)" .fit/fmt/.clang-format-installed prerequisite (apache#8950) Make the autopep8 clang-format targets quieter (apache#8944) Add option to disable JIT in lua plugin (apache#8618) Fix doc formatting for plugin remap_stats (apache#8942) Fix doc formatting for rate_limit plugin (apache#8943) Clear lua plugin http context after each hook handler (apache#8607) LGTM: Remove function declaration in block (HdrHeap.cc) (apache#8588) ESI processing when origin returns 304 response (apache#8563) call je_dallocx with flags when needed (apache#8547) Updated ChangeLog ... Conflicts: CHANGELOG-9.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lgtm.com/projects/g/apache/trafficserver/snapshot/163899fdeae142ed2f7b7bbd60eebecfceb5782a/files/proxy/hdrs/HdrHeap.cc?sort=name&dir=ASC&mode=heatmap#L57
These declarations seem just redundant because these are declared in included header files.