Promote PendingAction for general use. #8423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
approved these changes
Oct 14, 2021
I don't like that this is done at the same time with the promotion. It's not even a separate commit. It's not reviewer friendly because you can't simply see the additional changes, and we can't revert it separately if it has problems. |
SolidWallOfCode
force-pushed
the
promote-pendingaction
branch
from
7c3b1c9
to
d027947
Compare
|
Updated to remove the thread safety, I'll put that in a separate PR. |
SolidWallOfCode
force-pushed
the
promote-pendingaction
branch
from
d027947
to
4984fd3
Compare
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Fix parent_select optional scheme (apache#8831) Add `#pragma once` for PendingAction.h (apache#8846) Promote class PendingAction from HttpSM.h for use in other classes. (apache#8423) Fixes leak in SNIAction name globbing (apache#8827) Handle opentelemetry-cpp v1.3.0 upgrade for otel_tracer plugin (apache#8834) Fix overflow conditions in prefetch plugin (apache#8660) Remove incorrect comment from base64 functions (apache#8835) Add autest to cover updates to cache with alternates (apache#8779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PendingActionis a class used inHttpSMto safely tracking pending actions. This is generally useful. In particular there is a race condition inPluginVCwhich should be fixed by using this class.In addition to promoting this out of "HttpSM.h" for general use, the implementation has been adjusted for greater thread safety. Multiple threads can safely assign to the instance, with the guarantee that all actions except the one stored in the instance have been canceled.