Fix timeout checks of NetHandler::manage_active_queue() #8287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaori335
commented
Aug 27, 2021
| continue; | ||
| } | ||
| if ((ne->inactivity_timeout_in && ne->next_inactivity_timeout_at <= now) || | ||
| (ne->active_timeout_in && ne->next_activity_timeout_at <= now)) { |
Contributor
Author
There was a problem hiding this comment.
@bryancall Do you remember why inactivity_timeout_in/active_timeout_in are checked instead of next_inactivity_timeout_at/next_activity_timeout_at by a80b4f3 ?
Member
|
Just a comment on the autest failure of double before I kick it off again. Looks like another issue of traffic_server not able to listen on the ports automatically selected for it. Much like we were seeing in tls_hooks11 a few days ago. From manager.log |
Contributor
|
[approve ci] |
shinrich
approved these changes
Oct 21, 2021
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
Looks reasonable. I assume it is checking inactivity_timeout_in because the logic is checking whether the timeout is set at all. But if we are clearing the next timeout out while read/write is disabled, your change makes sense.
bryancall
pushed a commit
that referenced
this pull request
Oct 29, 2021
(cherry picked from commit 5e53758)
zwoop
pushed a commit
that referenced
this pull request
Nov 8, 2021
(cherry picked from commit 5e53758)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: (50 commits) Updated ChangeLog Reject Transfer-Encoding in pre-HTTP/1.1 requests (apache#8451) Better TLS Secrets Truncation. (apache#8489) ssl_secret debug printing: print only the first 50 bytes (apache#8483) Define TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI (apache#8477) Fix case of brotli (apache#8476) TSSslSecretSet: Update SSL_CTX TLS Secrets (apache#8368) Adding doc/README.md (apache#8420) Doc: fix typos in Strategy documentation (apache#8408) Refactors and promotes the Txn Control mechanism with Get() and Set() (apache#8428) tests: Add shbang to python scripts with a main (apache#8430) Remove empty tests/unit_tests directoy+makefile (apache#8429) Adds new API: TSVConnSslSniGet (apache#8313) rate_limit: convert to using TSVConnSslSniGet (apache#8414) Update the Multiplexer Docs for Multplexed HTTPS Connections (apache#8440) bigobj: use automake to build test utilities (apache#8441) Make sni.yaml errors cause an unrecoverable TS crash at startup. (apache#8208) Fix timeout checks of NetHandler::manage_active_queue() (apache#8287) Fix Multiplexer POST/PUT Body Handling (apache#8439) Document proxy.config.memory.max_usage (apache#8450) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8273.