Revert "Remove UnixNetVConnection::startEvent - not actually called. (#7596)" + clang-analyzer fix #8184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#7596)" This reverts commit a56638f.
masaori335
commented
Jul 29, 2021
Contributor
Author
|
It's a bit weird that we don't see this clang-analyzer report on 8.1.x (#8180). Do we have any diffs? |
iocore/net/UnixNetVConnection.cc
Outdated
| connectUp(e->ethread, NO_FD); | ||
| } else { | ||
| lock.release(); | ||
| free(e->ethread); |
Member
There was a problem hiding this comment.
Should change to this->free(e->thread); to be clear on what's being invoked.
Contributor
Author
There was a problem hiding this comment.
It looks like this confused the clang-analyzer. Adding this fixed the report.
masaori335
force-pushed
the
fix-clang-analyzer-8182
branch
from
1a2decc to
b51ceb8
Compare
Contributor
Author
|
|
masaori335
changed the title
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a56638f.
Co-authored-by: Tomoaki Tanaka tomoatan@yahoo-corp.jp
Address a use-after-free on top of #8182.
https://ci.trafficserver.apache.org/clang-analyzer/github/8182/2021-07-28-135835-24348-1/report-26932e.html#EndPath