Changes HttpSM to be Proxy Allocated #8082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
approved these changes
Jul 19, 2021
Contributor
|
@zwoop can you post the performance numbers of having a proxy allocator for the HttpSM vs not? |
Contributor
Author
|
I've tried this on master, 9.1.x and 9.0.x branches, and on the 9.0.x branch, it will assert always. 9.1.x or master does not have this problem, I think something changed around either the class allocators or the constructor / destructors for the HttpSM. |
Contributor
Author
|
The performance increase is not tremendous, about 5%. It's possible it make more of a difference on other hardware platforms, where the costs of the atomic operations on the class allocator causes more contention. |
zwoop
added a commit
that referenced
this pull request
Aug 5, 2021
(cherry picked from commit 4682e8d)
Contributor
Author
|
Cherry-picked to v9.1.x branch. |
ezelkow1
added a commit
to ezelkow1/trafficserver
that referenced
this pull request
Mar 7, 2022
This reverts commit 6806795.
ezelkow1
added a commit
to ezelkow1/trafficserver
that referenced
this pull request
Mar 7, 2022
…he#6241)" This reverts commit b24f62f. Revert "Call constructors and destructors for H1/2 Session/Transaction via ClassAllocator (apache#7584)" This reverts commit a0dd3c2. Revert "Changes HttpSM to be Proxy Allocated (apache#8082)" This reverts commit 6806795.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few comments on this: