Skip to content

Add thread yeield to avoid busy waiting in LogObject::_checkout_write(). (#7576) #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezelkow1 merged 1 commit into from
Jun 1, 2021
Merged

Add thread yeield to avoid busy waiting in LogObject::_checkout_write(). (#7576) #7906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion proxy/logging/LogObject.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

#include <algorithm>
#include <vector>
#include <thread>

static bool
should_roll_on_time(Log::RollingEnabledValues roll)
Expand Down Expand Up @@ -462,7 +463,9 @@ LogObject::_checkout_write(size_t *write_offset, size_t bytes_needed)
break;

case LogBuffer::LB_RETRY:
// no more room, but another thread should be taking care of creating a new buffer, so try again
// no more room, but another thread should be taking care of creating a new buffer, so yield to let
// the other thread finish, then try again
std::this_thread::yield();
break;

case LogBuffer::LB_BUFFER_TOO_SMALL:
Expand Down