Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented May 10, 2021

This reverts commit 739994f (#7667).

At least 3 people faced the assertion failure I reported as #7705. If the issue is not going to be resolved soon, I'd like to take back my approval for the change and revert the commit causing the failure because the change was supposed to be just a cleanup.

The commit is already backported to 9.1.x branch and I confirmed the branch has the same issue.

@maskit maskit added the Revert label May 10, 2021
@maskit maskit added this to the 10.0.0 milestone May 10, 2021
@maskit maskit requested review from shinrich and zwoop May 10, 2021 08:57
@maskit maskit self-assigned this May 10, 2021
@maskit
Copy link
Member Author

maskit commented May 13, 2021

#7807 will fix the issue.

@maskit maskit closed this May 13, 2021
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants