-
Notifications
You must be signed in to change notification settings - Fork 851
Clean up HTTP version processing #7766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| /** @file | ||
|
|
||
| HTTPVersion - class to track the HTTP version | ||
|
|
||
| @section license License | ||
|
|
||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| class HTTPVersion | ||
| { | ||
| public: | ||
| HTTPVersion() {} | ||
| HTTPVersion(HTTPVersion const &that) = default; | ||
| explicit HTTPVersion(int version); | ||
| constexpr HTTPVersion(uint8_t ver_major, uint8_t ver_minor); | ||
|
|
||
| int operator==(const HTTPVersion &hv) const; | ||
| int operator!=(const HTTPVersion &hv) const; | ||
| int operator>(const HTTPVersion &hv) const; | ||
| int operator<(const HTTPVersion &hv) const; | ||
| int operator>=(const HTTPVersion &hv) const; | ||
| int operator<=(const HTTPVersion &hv) const; | ||
|
|
||
| uint8_t get_major() const; | ||
| uint8_t get_minor() const; | ||
| int get_flat_version() const; | ||
|
|
||
| private: | ||
| uint8_t vmajor = 0; | ||
| uint8_t vminor = 0; | ||
| }; | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline HTTPVersion::HTTPVersion(int version) | ||
| { | ||
| vmajor = (version >> 16) & 0xFFFF; | ||
| vminor = version & 0xFFFF; | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline constexpr HTTPVersion::HTTPVersion(uint8_t ver_major, uint8_t ver_minor) : vmajor(ver_major), vminor(ver_minor) {} | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline uint8_t | ||
| HTTPVersion::get_major() const | ||
| { | ||
| return vmajor; | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline uint8_t | ||
| HTTPVersion::get_minor() const | ||
| { | ||
| return vminor; | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::get_flat_version() const | ||
| { | ||
| return vmajor << 16 | vminor; | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator==(const HTTPVersion &hv) const | ||
| { | ||
| return vmajor == hv.get_major() && vminor == hv.get_minor(); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator!=(const HTTPVersion &hv) const | ||
| { | ||
| return !(*this == hv); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator>(const HTTPVersion &hv) const | ||
| { | ||
| return vmajor > hv.get_major() || (vmajor == hv.get_major() && vminor > hv.get_minor()); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator<(const HTTPVersion &hv) const | ||
| { | ||
| return vmajor < hv.get_major() || (vmajor == hv.get_major() && vminor < hv.get_minor()); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator>=(const HTTPVersion &hv) const | ||
| { | ||
| return vmajor > hv.get_major() || (vmajor == hv.get_major() && vminor >= hv.get_minor()); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| inline int | ||
| HTTPVersion::operator<=(const HTTPVersion &hv) const | ||
| { | ||
| return vmajor < hv.get_major() || (vmajor == hv.get_major() && vminor <= hv.get_minor()); | ||
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| -------------------------------------------------------------------------*/ | ||
|
|
||
| constexpr HTTPVersion HTTP_INVALID{0, 0}; | ||
| constexpr HTTPVersion HTTP_0_9{0, 9}; | ||
| constexpr HTTPVersion HTTP_1_0{1, 0}; | ||
| constexpr HTTPVersion HTTP_1_1{1, 1}; | ||
| constexpr HTTPVersion HTTP_2_0{2, 0}; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need a HTTP_3_0 for QUIC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will once we support QUIC to origin.