Skip to content

Add default implementation for allow_half_open #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinrich merged 1 commit into from
Mar 29, 2021
Merged

Add default implementation for allow_half_open #7630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions proxy/ProxyTransaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,9 @@ ProxyTransaction::has_request_body(int64_t request_content_length, bool is_chunk
{
return request_content_length > 0 || is_chunked;
}

bool
ProxyTransaction::allow_half_open() const
{
return false;
}
2 changes: 1 addition & 1 deletion proxy/ProxyTransaction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class ProxyTransaction : public VConnection
virtual int get_transaction_id() const = 0;
virtual int get_transaction_priority_weight() const;
virtual int get_transaction_priority_dependence() const;
virtual bool allow_half_open() const = 0;
virtual bool allow_half_open() const;
virtual void increment_client_transactions_stat() = 0;
virtual void decrement_client_transactions_stat() = 0;

Expand Down
7 changes: 0 additions & 7 deletions proxy/http2/Http2Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ class Http2Stream : public ProxyTransaction
bool is_active_timeout_expired(ink_hrtime now);
bool is_inactive_timeout_expired(ink_hrtime now);

bool allow_half_open() const override;
bool is_first_transaction() const override;
void increment_client_transactions_stat() override;
void decrement_client_transactions_stat() override;
Expand Down Expand Up @@ -294,12 +293,6 @@ Http2Stream::payload_length_is_valid() const
return content_length == 0 || content_length == data_length;
}

inline bool
Http2Stream::allow_half_open() const
{
return false;
}

inline bool
Http2Stream::is_client_state_writeable() const
{
Expand Down
6 changes: 0 additions & 6 deletions proxy/http3/Http3Transaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ HQTransaction::release(IOBufferReader *r)
this->_sm = nullptr;
}

bool
HQTransaction::allow_half_open() const
{
return false;
}

VIO *
HQTransaction::do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf)
{
Expand Down
1 change: 0 additions & 1 deletion proxy/http3/Http3Transaction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class HQTransaction : public ProxyTransaction
void set_inactivity_timeout(ink_hrtime timeout_in) override;
void cancel_inactivity_timeout() override;
void transaction_done() override;
bool allow_half_open() const override;
void release(IOBufferReader *r) override;
int get_transaction_id() const override;
void increment_client_transactions_stat() override;
Expand Down