Skip to content

Adapt to continuation changes in write event handling #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shinrich wants to merge 2 commits into from
Closed

Adapt to continuation changes in write event handling #7578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ae76e
Adapt to continuation changes in write event handling
shinrich Mar 4, 2021
b52fb0c
Declare the variable
shinrich Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions iocore/net/UnixNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection *vc, EThread *thread)
{
NetState *s = &vc->write;
ProxyMutex *mutex = thread->mutex.get();
Continuation *c = vc->write.vio.cont;

MUTEX_TRY_LOCK(lock, s->vio.mutex, thread);

Expand Down Expand Up @@ -431,6 +432,9 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection *vc, EThread *thread)
if (towrite != ntodo && buf.writer()->write_avail()) {
if (write_signal_and_update(VC_EVENT_WRITE_READY, vc) != EVENT_CONT) {
return;
} else if (c != s->vio.cont) { /* The write vio was updated in the handler */
write_reschedule(nh, vc);
return;
}
Copy link
Contributor

@vmamidi vmamidi Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check for continuation change all the time?

Copy link
Member Author

@shinrich shinrich May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I see another call in this function that should be checked.


ntodo = s->vio.ntodo();
Expand Down