Skip to content

Replace ::exit() with _exit() to avoid secondary cleanup cores #7395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinrich merged 1 commit into from
Dec 15, 2020
Merged

Replace ::exit() with _exit() to avoid secondary cleanup cores #7395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tscore/ink_error.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ void
ink_fatal_va(const char *fmt, va_list ap)
{
fatal_va("Fatal: ", fmt, ap);
::exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good a status as any.
_exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good a status as any.
}

void
Expand All @@ -64,14 +64,14 @@ ink_fatal(const char *message_format, ...)
fatal_va("Fatal: ", message_format, ap);
va_end(ap);

::exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good a status as any.
_exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good a status as any.
}

void
ink_emergency_va(const char *fmt, va_list ap)
{
fatal_va("Emergency: ", fmt, ap);
::exit(UNRECOVERABLE_EXIT);
_exit(UNRECOVERABLE_EXIT);
}

void
Expand All @@ -84,7 +84,7 @@ ink_emergency(const char *message_format, ...)
// Should never reach here since ink_emergency_va calls exit()
va_end(ap);

::exit(UNRECOVERABLE_EXIT);
_exit(UNRECOVERABLE_EXIT);
}

void
Expand Down