Fix volume/stripe calcs when using forced volumes

[gtenev]

Fixed problems with initialization of cache volumes when at least
one volume is being forced to a specific "exclusive" span.

Problem description

Disks are cleared in the following configuration where volume sizes are
specified using percentages and also one of the volumes is forced to a
specific span (disk):

storage.config:
  /dev/disk1
  /dev/disk2 volume=3 # <- exclusive span forced to a specific volume

volume.config:
  volume=1 scheme=http size=50%
  volume=2 scheme=http size=50%
  volume=3 scheme=http size=512 # <- volume forced to an exclusive span

During the first start ATS identifies the cleared disks and does the following:
(1) creates and spreads new volume 1 and 2 blocks across disk1 and disk2
(2) deletes all volume 1 and 2 blocks from disk2 to make space for volume 3
(3) creates new volume 3 that takes over the whole disk2.

In step (1) volumes are caclulated larger and spread to disk2 only to be
deleted in step (2) to make space for the forced volume 3.

During the initial start the global volume list cp_list would end up
containing "zombie" CacheVol instances which correspond to the volume 1
and 2 blocks deleted from disk2 to make space for the volume 3 and the
mapping of domains to volumes (hosting.config) could end up mapping
to any of the deleted volume blocks.

This problem disappears after restart since cp_list is initialized
from the disks and cp_list will contain only valid CacheVol instances.

The fix

This fix prevents this from happening by making sure all volumes meant
to have "exclusive" disks are created first to make sure span free
spaces are updated correctly and by excluding the size of
the "exclusive" disks from the total cache size used for volume size
calculations when sizes are specified in percentages (volume.config).

[vmamidi]

@scw00 @SolidWallOfCode did you guys get a chance to look at this PR?

[scw00]

static_cast please

[scw00]

Is this a feature that adding exclusively disk without clearing all disk ?

[SolidWallOfCode]

No C-style casts. Because it's a void *, static_cast should work. You could try

new_cp->disk_vols = static_cast<decltype(new_cp->disk_vols)>(ats_malloc(...));

to be extra fancy :-P

[SolidWallOfCode]

"or did not exist to begin with"

[SolidWallOfCode]

Looks reasonable, I only have some stylistic requests.

[zwoop]

Cherry-picked to v9.0.x branch.

[gtenev]

@scw00 and @SolidWallOfCode thanks for the review!

The C-style casts were remnants of old code, C-style casts are all over the place in Cache.cc. Since this PR got merged before I pushed the fix, in the interest of time I may address your "stylistic request" in a following PR.

[gtenev]

@zwoop here is the 8.1.x back port PR #7001