Reduce case sensitivity of chunked_encoding test #6948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
approved these changes
Jun 24, 2020
Contributor
|
[approve ci autest] |
Contributor
|
Shouldn't we change the server back to Transfer-Encoding? ATS shouldn't be changing the case of heades and we should detect if is does. |
Member
|
I'm curious which change made the difference. |
Member
|
#6935 passed autest without this change. I think we should find the root cause. |
Member
Author
|
Yes, I took a bit of time to figure out why there is a difference. And I don't understand. Will look some more. |
randall
requested changes
Jun 30, 2020
Contributor
randall
left a comment
randall
left a comment
There was a problem hiding this comment.
Waiting for answer about why the case changed (to prevent accidental merge)
Member
Author
|
Looked into this some more. If fact the failure in PR #6908 is due to a legitimate failure. Not being strict on the case change would be wrong. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed PR #6908 and PR #6935 are getting blocked by the chunked_encoding test. Looks like there was a change in case of Transfer-Encoding -> Transfer-encoding
This PR at least eliminates caring about the case of the E