Fix inactivity timeout on QUIC #5839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event name was changed by apache#5824
masaori335
reviewed
Aug 19, 2019
| this->_handle_path_validation_timeout(data); | ||
| break; | ||
| case EVENT_IMMEDIATE: | ||
| case VC_EVENT_INACTIVITY_TIMEOUT: |
Contributor
There was a problem hiding this comment.
After #5839, InactivityCop will send VC_EVENT_ACTIVE_TIMEOUT event too.
We don't need to handle it correctly on this PR, but it'd better adding a TODO comment.
Member
Author
There was a problem hiding this comment.
Ah, ACTIVE_TIMEOUT. Yeah, I realized that we don't have code for active timeout. I'll create an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event name was changed by #5824