Skip to content

Conversation

@randall
Copy link
Contributor

@randall randall commented Apr 24, 2019

This implements the deprecation noted in 26b3087

@randall randall added this to the 9.0.0 milestone Apr 24, 2019
@randall randall self-assigned this Apr 24, 2019
@randall randall force-pushed the remove_log_collation branch from a77eefc to 7897250 Compare April 24, 2019 09:36
zwoop
zwoop previously approved these changes Apr 24, 2019
Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@randall randall force-pushed the remove_log_collation branch 3 times, most recently from 171c56a to 51c5eb4 Compare April 25, 2019 01:16
This implements the deprecation noted in 26b3087
@randall randall force-pushed the remove_log_collation branch from 51c5eb4 to ee8cb9a Compare April 25, 2019 02:05
@randall
Copy link
Contributor Author

randall commented Apr 25, 2019

[approve ci autest]

@randall randall merged commit 82d5644 into apache:master Apr 27, 2019
@randall randall deleted the remove_log_collation branch April 27, 2019 01:34
@zwoop
Copy link
Contributor

zwoop commented Apr 29, 2019

This seems to cause serious problems, log rotation stops working, and I'm getting ASAN errors as well:

==27218==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000015d40 at pc 0x2b32d4cbc158 bp 0x2b32ddd2f2f0 sp 0x2b32ddd2f2e0
READ of size 4 at 0x602000015d40 thread T11 ([LOG_FLUSH])
    #0 0x2b32d4cbc157 in EventNotify::signal() /usr/local/src/trafficserver/src/tscore/EventNotify.cc:73
    #1 0x93386b in LogObject::_checkout_write(unsigned long*, unsigned long) /usr/local/src/trafficserver/proxy/logging/LogObject.cc:409
    #2 0x93aba8 in LogObject::force_new_buffer() /usr/local/src/trafficserver/proxy/logging/LogObject.h:250
    #3 0x93aba8 in LogObject::check_buffer_expiration(long) /usr/local/src/trafficserver/proxy/logging/LogObject.cc:762
    #4 0x93aba8 in LogObjectManager::check_buffer_expiration(long) /usr/local/src/trafficserver/proxy/logging/LogObject.cc:1067
    #5 0x8c50a4 in Log::periodic_tasks(long) /usr/local/src/trafficserver/proxy/logging/Log.cc:234
    #6 0x8c8910 in Log::flush_thread_main(void*) /usr/local/src/trafficserver/proxy/logging/Log.cc:1356
    #7 0x8d3a3c in LoggingFlushContinuation::mainEvent(int, void*) /usr/local/src/trafficserver/proxy/logging/Log.cc:285
    #8 0xeba16b in Continuation::handleEvent(int, void*) /usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:190
    #9 0xeba16b in EThread::execute() /usr/local/src/trafficserver/iocore/eventsystem/UnixEThread.cc:318
    #10 0xeb4a7a in spawn_thread_internal /usr/local/src/trafficserver/iocore/eventsystem/Thread.cc:92
    #11 0x2b32d6801dd4 in start_thread (/lib64/libpthread.so.0+0x7dd4)
    #12 0x2b32d7536eac in __clone (/lib64/libc.so.6+0xfdeac)

0x602000015d40 is located 0 bytes to the right of 16-byte region [0x602000015d30,0x602000015d40)
allocated by thread T0 ([TS_MAIN]) here:
    #0 0x2b32d3d25368 in operator new[](unsigned long) (/lib64/libasan.so.4+0xe0368)
    #1 0x8c991e in Log::create_threads() /usr/local/src/trafficserver/proxy/logging/Log.cc:1023
    #2 0x8ca3ac in Log::init_when_enabled() /usr/local/src/trafficserver/proxy/logging/Log.cc:1007
    #3 0x8d2232 in Log::init(int) /usr/local/src/trafficserver/proxy/logging/Log.cc:980
    #4 0x4b8dc5 in main traffic_server/traffic_server.cc:1886
    #5 0x2b32d745b3d4 in __libc_start_main (/lib64/libc.so.6+0x223d4)

@randall randall restored the remove_log_collation branch May 4, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants