TS-3944: Add documentation for TSHttpTxnServerAddrSet to clarify when it can be called. #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it must be called.
Contributor
There was a problem hiding this comment.
I thought you want TSHttpTxnServerAddrSet ?
Member
Author
There was a problem hiding this comment.
Thanks, I messed up the cut and paste. I'll fix it before committing.
maskit
pushed a commit
to maskit/trafficserver
that referenced
this pull request
Feb 2, 2017
* asf/master: (392 commits) Doh, chomp does not trim WS ... Make sure any trailing WS is removed from the Jira summary Change the changelog.pl script to use /usr/bin/env to find perl TS-4089: clang-format [TS-4091] addressing internal headers This close apache#387. TS-4089: Fixed coverity issues in parent selection. TS-4074: Escape backslashes in user/group/machine name TS-4043: Prevent bogus FQDN characters in host header This close apache#356. TS-3418: clang-format This closes apache#190. This closes apache#321. TS-4071: Unused mutex Diags::rotate_lock TS-3418: Various style fixes. TS-3418: Refactored parent selection to add a secondary parent consistent hash ring. This closes apache#368. TS-4084: Empty README.md file TS-4079: Support for arbitrary esi vars through HTTP request headers. This closes apache#378 TS-3944: Add documentation for TSHttpTxnServerAddrSet to clarify when it must be called. This close apache#385. Clang format. TS-3908: Fix clang errors in WCCP. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find any current documentation on this function and so the use is unclear. Documenting it means we can make clear that it must be called sufficiently early in the transaction to be effective.