TSHttpTxnOutgoingAddrSet: Add documentation, implement for HTTP/2. #3421
Conversation
| new_session->host_res_style = ats_host_res_from(client_ip->sa_family, options.host_res_preference); | ||
| new_session->outbound_ip4 = options.outbound_ip4; | ||
| new_session->outbound_ip6 = options.outbound_ip6; | ||
| new_session->outbound_port = options.outbound_port; |
There was a problem hiding this comment.
Curious, why not just have a "new_session->options = options" ?
There was a problem hiding this comment.
Historical inertia would be my guess. When I first started mucking with this I had no idea what I was doing, so I followed the existing copies. At this point, I'd lean more toward having the NetVC track the Accept object and not copy at all. It would be a useful clean up project for a mentored beginner.
There was a problem hiding this comment.
Make it so #1. File an Issue so we don't forget ?
There was a problem hiding this comment.
Stumbled across this while merging in this change locally. Didn't see an issue for this, so created #3489.
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
I don't have any concern from a perspective of H2 (and QUIC).
4 participants
Control of the local IP address for outbound connections should (1) be documented and (2) work for HTTP/2 just as for HTTP. This moves the support for that down to the
ProxyClientSessionandProxyClientTransactionbecause it's common for all subclasses.