Skip to content

Conversation

@zizhong
Copy link
Member

@zizhong zizhong commented Jul 21, 2015

Extending the custom log fields to support incoming server (interface) ip.

@bgaff
Copy link
Member

bgaff commented Jul 21, 2015

I worked with @zizhong on this pull request and it looks good to me.

@jpeach
Copy link
Contributor

jpeach commented Jul 21, 2015

Looks quite reasonable. I think we can improve the commit messages though. These guidelines are good advice.

@ericcarlschwartz
Copy link
Contributor

This looks like it's solving/a duplicate of https://issues.apache.org/jira/browse/TS-2152

The code looks good to me too. If you're renaming commits per @jpeach's comments might want to reflect this & we can close out both issues.

@bgaff
Copy link
Member

bgaff commented Jul 22, 2015

Hi @ericcarlschwartz , if you're cool with he proposed patch I'll land this one and we can close out TS-2152 as a dupe.

@zwoop
Copy link
Contributor

zwoop commented Jul 22, 2015

Yeah, close TS-2152 as a dupe of TS-3780, since there's so much work done on this PR already. In general, please file Jira's before work / pull requests are done, such that we avoid (minimize) risk of duplicated efforts / work.

@ericcarlschwartz
Copy link
Contributor

Sounds good to me just wanted to make sure they both get closed out!

@asfgit asfgit merged commit 727f6ca into apache:master Jul 23, 2015
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Feb 1, 2017
YTSATS-909: Incorrectly freeing Http1ClientSession while setting up t…
@zwoop zwoop added this to the Old milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants