Skip to content

Update connection window size, before any stream specific handling #12910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yknoya wants to merge 1 commit into
base: 9.2.x
Choose a base branch
from
+6 −3
Open

Update connection window size, before any stream specific handling #12910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions proxy/http2/Http2ConnectionState.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ rcv_data_frame(Http2ConnectionState &cstate, const Http2Frame &frame)

Http2StreamDebug(cstate.session, id, "Received DATA frame");

// Update connection window size, before any stream specific handling
cstate.decrement_server_rwnd(payload_length);

if (cstate.get_zombie_event()) {
Warning("Data frame for zombied session %" PRId64, cstate.session->get_connection_id());
}
Expand Down Expand Up @@ -162,7 +165,8 @@ rcv_data_frame(Http2ConnectionState &cstate, const Http2Frame &frame)
}

// Check whether Window Size is acceptable
if (!cstate.server_rwnd_is_shrinking && cstate.server_rwnd() < payload_length) {
// compare to 0 because we already decreased the connection rwnd with payload_length
if (!cstate.server_rwnd_is_shrinking && cstate.server_rwnd() < 0) {
return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_CONNECTION, Http2ErrorCode::HTTP2_ERROR_FLOW_CONTROL_ERROR,
"recv data cstate.server_rwnd < payload_length");
}
Expand All @@ -171,8 +175,7 @@ rcv_data_frame(Http2ConnectionState &cstate, const Http2Frame &frame)
"recv data stream->server_rwnd < payload_length");
}

// Update Window size
cstate.decrement_server_rwnd(payload_length);
// Update stream window size
stream->decrement_server_rwnd(payload_length);

if (is_debug_tag_set("http2_con")) {
Expand Down