Skip to content

Fix Coverity UNINIT issues #12842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryancall wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Coverity UNINIT issues #12842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fee40e6
Fix uninitialized DiagsConfigState in reconfigure_diags
bryancall Jan 29, 2026
6cb2a39
Fix uninitialized ParsedValue in ParsedConfigCache::parse
bryancall Jan 29, 2026
a3fa311
Fix uninitialized TLSClientHelloSummary in test_ja4
bryancall Jan 29, 2026
f74d548
Fix uninitialized IPRange in background_fetch and cache_fill plugins
bryancall Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/background_fetch/configs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ BgFetchConfig::readConfig(const char *config_file)
if ("Client-IP"_tv == cfg_name) {
swoc::IPRange r;
// '*' is special - match any address. Signalled by empty range.
if (cfg_value.size() != 1 || cfg_value.front() == '*') {
if (cfg_value.size() != 1 || cfg_value.front() != '*') {
if (!r.load(cfg_value)) { // assume if it loads, it's not empty.
TSError("[%s] invalid IP address range %.*s, skipping config value", PLUGIN_NAME, int(cfg_value.size()),
cfg_value.data());
Expand Down
2 changes: 1 addition & 1 deletion plugins/experimental/cache_fill/configs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ BgFetchConfig::readConfig(const char *config_file)
if ("Client-IP"_tv == cfg_name) {
swoc::IPRange r;
// '*' is special - match any address. Signalled by empty range.
if (cfg_value.size() != 1 || cfg_value.front() == '*') {
if (cfg_value.size() != 1 || cfg_value.front() != '*') {
if (!r.load(cfg_value)) { // assume if it loads, it's not empty.
TSError("[%s] invalid IP address range %.*s, skipping config value", PLUGIN_NAME, int(cfg_value.size()),
cfg_value.data());
Expand Down
2 changes: 1 addition & 1 deletion plugins/experimental/ja4_fingerprint/test_ja4.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ static std::string inc(std::string_view sv);

TEST_CASE("JA4")
{
JA4::TLSClientHelloSummary TLS_summary;
JA4::TLSClientHelloSummary TLS_summary{};

SECTION("Given the protocol is TCP, "
"when we create a JA4 fingerprint, "
Expand Down
2 changes: 1 addition & 1 deletion src/proxy/http/HttpConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ ParsedConfigCache::lookup_impl(TSOverridableConfigKey key, std::string_view valu
ParsedConfigCache::ParsedValue
ParsedConfigCache::parse(TSOverridableConfigKey key, std::string_view value)
{
ParsedValue result;
ParsedValue result{};

// Store the string value - the parsed structures may reference this.
result.conf_value_storage = std::string(value);
Expand Down
2 changes: 1 addition & 1 deletion src/proxy/shared/DiagsConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void
DiagsConfig::reconfigure_diags()
{
int i;
DiagsConfigState c;
DiagsConfigState c{};
bool found, all_found;

static struct {
Expand Down