Reset HttpCacheSM on following redirect #12182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We face an issue that
http.current_active_client_connectionsmetrics keep increasing. After investigation with @cmcfarlen and @moonchen, we foundHttpSMhangs onstate_cache_open_readwhen it follows redirect andHttpCacheSM::captive_actionwas cancelled. BecauseHttpCacheSM::state_cache_open_readdoes nothing.trafficserver/src/proxy/http/HttpCacheSM.cc
Lines 106 to 112 in b1e9327
To fix the issue, this PR does reset
captive_action.cancelledand other counters ofHttpCacheSMon following redirect.From our testing, this patch seems working, however,
captive_actionandpending_actionrelated code seems pretty odd. They should be fixed.