Skip to content

Conversation

@JosiahWI
Copy link
Contributor

The StripeSM class retains all the evacuation data and the mutex.

The `StripeSM` class retains all the evacuation data and the mutex.
@JosiahWI JosiahWI added this to the 10.1.0 milestone Jul 18, 2024
@JosiahWI JosiahWI self-assigned this Jul 18, 2024
@JosiahWI JosiahWI force-pushed the refactor/split-stripe branch from cea13d3 to bb94593 Compare July 18, 2024 13:47
@bryancall bryancall requested a review from cmcfarlen July 22, 2024 22:25
Copy link
Contributor

@cmcfarlen cmcfarlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the incentive to do this? Are there plans to use the split out Stripe class on its own in some way? It seems like without the lock from Continuation, this can't be used on its own.

Maybe consider making Stripe or some superclass of Stripe an interface to clean that up and have StripeSM implement the aspects that integrate with Continuations and locking.

@JosiahWI
Copy link
Contributor Author

This is an code organization change. The long term incentive is separation of concerns, and the short term goal is to split up massive source files into smaller, separate source files. In this case, we're separating the data structure from the event handling. The separation is still subpar because the event handling methods touch the data structure too much, but it's a start. This will be followed by a PR to move all the StripeSM event handling into a new StripeSM.cc source file.

@JosiahWI JosiahWI merged commit ed0a36d into apache:master Jul 25, 2024
@JosiahWI JosiahWI deleted the refactor/split-stripe branch July 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants