TSFile - remove from background_fetch plugin. #10909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Any way we could get an Au test for this plugin merged first? |
Contributor
Sorry I'm not seeing where/how this tests the plugin. |
Member
Author
|
Hmmm, I'll have to double check. |
ezelkow1
requested changes
Dec 19, 2023
Member
There was a problem hiding this comment.
that extern DbgCtl Bg_dbg_ctl should probably be
static DbgCtl Bg_dbg_ctl{PLUGIN_NAME};
Plugin will build as-is but not run like that due to the externed dbg
Contributor
There was a problem hiding this comment.
Could just add:
DbgCtl Bg_dbg_ctl{PLUGIN_NAME};
to config.cc .
Contributor
|
@ezelkow1 is going to take over this PR |
Contributor
|
This was fixed with #10980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSFileand related plugin API are being deprecated. This removes those from thebackground_fetchplugin, along with some other clean up.