Skip to content

Rename vol to stripe (defined in the CacheVC.h) #10737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masaori335 merged 1 commit into from
Nov 29, 2023
Merged

Rename vol to stripe (defined in the CacheVC.h) #10737

masaori335 merged 1 commit into from
Nov 29, 2023

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Nov 7, 2023

Part of #10628.

Main changes are renaming members of CacheVC.

Stripe *vol;
int scanVol(int event, Event *e);
char *scan_vol_map;

to

Stripe *stripe;
int scanStripe(int event, Event *e);
char *scan_stripe_map;

@masaori335 masaori335 added this to the 10.0.0 milestone Nov 7, 2023
@masaori335 masaori335 self-assigned this Nov 7, 2023
@masaori335
Copy link
Contributor Author

masaori335 commented Nov 7, 2023

Draft until #10710 is merged.

bneradt
bneradt previously approved these changes Nov 9, 2023
View reviewed changes
@masaori335 masaori335 force-pushed the cleanup-cache-rename-vol-2 branch from 4129634 to bb8e5ce Compare November 15, 2023 16:16
@masaori335 masaori335 marked this pull request as ready for review November 15, 2023 16:16
@masaori335 masaori335 force-pushed the cleanup-cache-rename-vol-2 branch from bb8e5ce to dd240a7 Compare November 28, 2023 02:57
@masaori335
Copy link
Contributor Author

masaori335 commented Nov 28, 2023

Resolved conflicts. Please take another look.

@masaori335 masaori335 merged commit 127071e into apache:master Nov 29, 2023
phongn pushed a commit to phongn/trafficserver that referenced this pull request Feb 1, 2024
@masaori335 @phongn
Rename CacheVC::vol to stripe (apache#10737)
6ecff6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt left review comments

+1 more reviewer

@SolidWallOfCode SolidWallOfCode SolidWallOfCode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@masaori335 masaori335

Labels

Cache Cleanup

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@masaori335 @SolidWallOfCode @bneradt