proxy.config.net.per_client.max_connections_in #10688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
commented
Oct 28, 2023
masaori335
reviewed
Oct 29, 2023
bneradt
force-pushed
the
per_client_connection_max
branch
from
7f87404 to
88eecf1
Compare
serrislew
reviewed
Oct 30, 2023
bneradt
force-pushed
the
per_client_connection_max
branch
from
88eecf1 to
ed50c32
Compare
bneradt
force-pushed
the
per_client_connection_max
branch
9 times, most recently
from
7c77d62 to
353b57f
Compare
bneradt
force-pushed
the
per_client_connection_max
branch
2 times, most recently
from
a633e1f to
89fbe0c
Compare
bneradt
force-pushed
the
per_client_connection_max
branch
2 times, most recently
from
5469af8 to
7c9180e
Compare
This implements proxy.config.net.per_client.max_connections_in which allows the user to configure a per client IP incoming maximum number of concurrent connections. This is the client-side analogue to proxy.config.http.per_server.connection.max. This also adds metrics and Group cleanup.
bneradt
force-pushed
the
per_client_connection_max
branch
from
7c9180e to
6b92998
Compare
Member
SolidWallOfCode
left a comment
SolidWallOfCode
left a comment
There was a problem hiding this comment.
Just one issue I saw in this review.
SolidWallOfCode
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements proxy.config.net.per_client.max_connections_in which
allows the user to configure a per client IP incoming maximum number of
concurrent connections. This is the client-side analogue to
proxy.config.http.per_server.connection.max.