-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/monitor peers flag #7672
Feature/monitor peers flag #7672
Conversation
NOTE: This Does require |
Codecov Report
@@ Coverage Diff @@
## master #7672 +/- ##
=============================================
- Coverage 65.05% 26.95% -38.11%
Complexity 98 98
=============================================
Files 314 686 +372
Lines 12365 80539 +68174
Branches 907 90 -817
=============================================
+ Hits 8044 21706 +13662
- Misses 3968 56761 +52793
- Partials 353 2072 +1719
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 568 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works as intended.
* Adding functions and config for monitor peer flag * Adding tests for the changes and updating files * Adding proper config file * Adding readme documentation for the config change * Adding prior health client default value * Updating CHANGELOG file * Adding yamlv3 vendor file(s) * Adding updated go.mod file * Fixing yamlv3 dependancy issue * Trying this module.txt file again * Adding the license lines. * Fixing default value setting * Removing some logging which was meant for testing. --------- Co-authored-by: Tyler Morgan <tylermorgan210@gmail.com>
During
strategies.yaml
creation, the file contains hosts which are&peer#
if they are inside the same cache group. The health of peers is currently not provide value. So having the ability to turn off the monitoring of peers since no traffic should be going to them, helps reduce computation and memory utilization. This also slims down the logs from unnecessary chatter.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
This PR includes an updated copy of
tc-health-client.json
for testing. Additionally, thetmagent_test.go
test has updated theTestReadStrategiesDotYaml
with tests for testing from reading from thetc-health-client.json
config file, but also a manualtrue
andfalse
value, with the proper expected results checked.PR submission checklist