TPv2 Abstract Table Class #7336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially a wrapper for the generic table for the common case of most data tables.
ocket8888
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new abstract class that encompasses the basic, common behavior of generic TPv2 tables. It also converts the Cache Groups, Regions, and Divisions tables to use it, to demonstrate its use.
The idea here is to ease creation of a common type of component. It's possible that instead we'd want to just make the generic table itself abstract and collapse the two. Idk. Really just interested in feedback at this point.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Don't. I'll bother writing tests if people think this is even a good idea.
PR submission checklist