-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscure sensitive Traffic Portal table fields #7121
Open
ocket8888
wants to merge
13
commits into
apache:master
Choose a base branch
from
ocket8888:tp/obscure-sensitive-table-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Obscure sensitive Traffic Portal table fields #7121
ocket8888
wants to merge
13
commits into
apache:master
from
ocket8888:tp/obscure-sensitive-table-fields
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, ILO Password was not included at all
…er on Delivery Services
…filter on Delivery Services I also fixed rampant misuse of anchors and buttons in place of each other and moved styling for a form into the forms stylesheet.
…servers Also fixed misuses of HTML elements, mostly anchors and buttons.
…r on Delivery Services Also fixed rampant misuse of HTML elements.
ocket8888
added
Traffic Portal v1
related to Traffic Portal version 1
low impact
affects only a small portion of a CDN, and cannot itself break one
improvement
The functionality exists but it could be improved in some way.
labels
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
The functionality exists but it could be improved in some way.
low impact
affects only a small portion of a CDN, and cannot itself break one
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes to TP tables to hide potentially sensitive fields behind a checkbox setting. To make things easier, I also eliminated a few tables that could be reproduced as filters on existing tables.
With #6981 merged, this fixes #6953.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Check the tables for servers and Delivery Services and verify that sensitive columns aren't shown unless the relevant setting is checked.
PR submission checklist