Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscure sensitive Traffic Portal table fields #7121

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ocket8888
Copy link
Contributor

@ocket8888 ocket8888 commented Oct 11, 2022

Implements changes to TP tables to hide potentially sensitive fields behind a checkbox setting. To make things easier, I also eliminated a few tables that could be reproduced as filters on existing tables.

With #6981 merged, this fixes #6953.


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Check the tables for servers and Delivery Services and verify that sensitive columns aren't shown unless the relevant setting is checked.

PR submission checklist

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sensitive fields require extra click to show contents in TP
1 participant