User can update parent tenant to have their child tenant as a new parent

[dpham692]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Portal
• Traffic Ops

Current behavior:

User can update parent tenant to have their child tenant as a new parent and the result is it will delete all the tenant from parent to the child

Expected behavior:

System should not let user update parent tenant to have their child tenant as a new parent tenant.

Minimal reproduction of the problem with instructions:

1. Create a tenant with few child tenant.
2. Update parent tenant to have child tenant and it will wipe out all the tenant.

Anything else:

[mitchell852]

good catch! yeah, obviously a tenant's parent cannot be a child of that tenant. 👍 - needs a simple parent check on PUT and if child return 400 with message.

[tcfdev]

@mitchell852 I'll take this one. Could you assign it to me?